On Tue, Jan 04, 2011 at 05:55:51PM +0200, [email protected] wrote:
> From: Ville Syrjälä <[email protected]>
> 
> When SourceValidate is performed on a window with IncludeInferiors
> sub-window mode, force an immediate update of all the automatically
> redirected windows, so that the current window contents will be up
> to date.

BTW I just realized that this patch won't work properly without the
damagedDescendants patch.

The problem is that compReportDamage marks the window as damaged before
SourceValidate is called during ProcCopyArea. compScreenUpdate would
then update the whole tree, before the CopyArea actually happens.

It looks like it can be fixed easily with DamageSetReportAfterOp.
Assuming we want to make the code work correctly without the
damagedDescendants patch. 

AFAICS changing to "report after" damage shouldn't cause any problems
even with the damagedDescendants patch, although it doesn't really
need it, since it would only update the subtree that isn't damaged by
ProcCopyArea.

-- 
Ville Syrjälä
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to