On Wed, 2011-01-05 at 08:48 +1000, Peter Hutterer wrote:

> same goes here btw, it'd be much nicer to read if you could swap $1
> etc. over for meaningful names. just reading this context, I'd have no
> idea what the error would convey.
> 
> same goes for e.g. process() too. but this can be a follow-up patch
> 

I have a TODO to fix them all, now that I have a sample one reviewed.

Same for Dan's suggestion regarding removal of superfluous fallback
case.
    *)
         ;;

Thanks

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to