On Wed, 5 Jan 2011 15:51:36 +0200, [email protected] wrote: > From: Ville Syrjälä <[email protected]> > > Use the "report after" damage mode for marking the automatically > redirected as damaged. Avoids a premature window tree update triggered > by compSourceValidate eg. during a CopyArea request. If the window is > marked as damaged before the CopyArea has actaully happened, the window > tree update will copy stale data to the parent.
I didn't comment on this one before because I didn't understand what it was doing. I think I've got it now -- the window damage gets registered in the Damage CopyArea wrapper, then SourceValidate is called which copies the window contents to its parent, then the data are copied. At this point, the window has no damage recorded and yet there are changed pixels. Given that the hierarchical composite damage fixes this problem in a cleaner fashion, should we just use that patch and not this one? Yeah, I know I said it was "just an optimization", but I think you've discovered that it isn't just an optimization... -- [email protected]
pgp6L0LZDxv7l.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
