On 01/31/11 04:01 AM, Erkki Seppälä wrote: > Variable "colormap_ret" goes out of scope > > Reviewed-by: Ander Conselvan de Oliveira > <[email protected]> > Signed-off-by: Erkki Seppälä <[email protected]> > --- > modules/im/ximcp/imRmAttr.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c > index b6d1e12..d62dfdb 100644 > --- a/modules/im/ximcp/imRmAttr.c > +++ b/modules/im/ximcp/imRmAttr.c > @@ -999,7 +999,7 @@ _XimEncodeStatusValue( > XIMArg *p) > { > if (res->xrm_name == XrmStringToQuark(XNStdColormap)) { > - XStandardColormap *colormap_ret; > + XStandardColormap *colormap_ret = NULL; > int count; > > if (!(XGetRGBColormaps(ic->core.im->core.display, > @@ -1007,6 +1007,7 @@ _XimEncodeStatusValue( > &count, (Atom)p->value))) > return False; > > + XFree(colormap_ret); > } else if (res->xrm_name == XrmStringToQuark(XNFontSet)) { > int list_ret; > XFontStruct **struct_list;
Reviewed-by: Alan Coopersmith <[email protected]> -- -Alan Coopersmith- [email protected] Oracle Solaris Platform Engineering: X Window System _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
