On 02/ 4/11 01:43 AM, Erkki Seppälä wrote:
> Properly handle the return value of XGetWindowProperty by considering
> if after the loop as well.
> 
> Using freed pointer "prop_ret"
> 
> There were numerous things wrong in how this function interacted with
> XGetWindowProperty.
> 
> None of the local variables were initialized and remained that way if
> the call to XGetWindowProperty returned 1 (not Succeed). That doesn't

s/Succeed/Success/

Nice explanation, made it easier to understand the changes to the code.

Reviewed-by: Alan Coopersmith <[email protected]>

-- 
        -Alan Coopersmith-        [email protected]
         Oracle Solaris Platform Engineering: X Window System
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to