On Mon, Feb 21, 2011 at 04:00:23PM +1000, Peter Hutterer wrote: > And copy into the master keyboard, not just the directly attached device. > > Signed-off-by: Peter Hutterer <[email protected]> > --- > On Fri, Feb 18, 2011 at 10:48:10AM +0100, Benjamin Tissoires wrote: > > >@@ -5883,9 +5884,8 @@ ProcXkbGetKbdByName(ClientPtr client) > > > nkn.changed|= XkbNKN_GeometryMask; > > > XkbSendNewKeyboardNotify(dev,&nkn); > > > > > >- if (!IsMaster(dev)&& !IsFloating(dev)) > > >+ if (!IsMaster(dev)&& (master = GetMaster(dev, MASTER_KEYBOARD))) > > > > I had a quick watch on the series, and this line worries me: I all > > the time consider putting an affectation in a test as a bug (or > > source of bug) as it's ambiguous. I know that it's valid in this > > case, but I don't like it. > > > > Sorry for the noise if you consider this as valid. ;) > > who am I to argue with that :) > > another change: the previous patch would still copy the keymap into the > attached master, not the master keyboard. fix this.
Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
