On Fri, Feb 25, 2011 at 09:02:20PM -0800, Keith Packard wrote:
> On Sat, 26 Feb 2011 00:00:39 +0100, Julien Cristau <[email protected]> 
> wrote:
> > Some architectures (hi, sparc!) are unhappy with unaligned memory
> > accesses.  So make sure the axisVal member of ValuatorClassRec has
> > sizeof(double) alignment to avoid crashes and test failures.
> 
> The 'standard' way to do this is to use a union to ensure correct
> alignment. Seems like simply moving the doubles to after the
> ValuatorClassRec and using a union between a double and the
> ValuatorClassRec would fix this without a lot of ugly pointer computations.

If we're going for more-invasive patches, why not just allocate axisVal
separately from ValuatorClassRec?

Cheers,
Daniel

Attachment: signature.asc
Description: Digital signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to