On Tue, Mar 08, 2011 at 02:13:47PM -0500, Adam Jackson wrote: > size needn't be a long. No change on ILP32 but, combined with the > previous change, 56 -> 40 bytes on LP64. > > Signed-off-by: Adam Jackson <[email protected]> > --- > include/propertyst.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/propertyst.h b/include/propertyst.h > index fd1148e..1edd11d 100644 > --- a/include/propertyst.h > +++ b/include/propertyst.h > @@ -58,8 +58,8 @@ typedef struct _Property { > struct _Property *next; > ATOM propertyName; > ATOM type; /* ignored by server */ > - short format; /* format of data for swapping - 8,16,32 */ > - long size; /* size of data in (format/8) bytes */ > + uint32_t format; /* format of data for swapping - 8,16,32 */ > + uint32_t size; /* size of data in (format/8) bytes */ > pointer data; /* private to client */ > PrivateRec *devPrivates; > } PropertyRec;
Being really pedantic again, can't these two be uint8_t or something? You've just grown format from 16 to 32 bytes. :P Aside from that: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
