On Tue, 15 Mar 2011 11:05:04 -0400, Adam Jackson <a...@redhat.com> wrote:
> - ErrorF("[dix] AddResource(%lx, %lx, %lx), client=%d \n",
> - (unsigned long)id, type, (unsigned long)value, client);
> + ErrorF("[dix] AddResource(%x, %x, %lx), client=%d \n",
> + id, type, (unsigned long)value, client);
<bikeshed>
I hate printf. This does assume that XID is the same as 'unsigned int'
on all machines. I think XID is still 'unsigned long' on 32-bit
machines, right? We could use %lx and a cast to unsigned long
everywhere...
</bikeshed>
Unless someone else has a concern that 'XID is not the same size as
'int', we should probably just use %x and eliminate the ugly cast.
Reviewed-by: Keith Packard <kei...@keithp.com>
--
keith.pack...@intel.com
pgpVJToOzvdWg.pgp
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
