On Wed, 2011-03-23 at 15:07 +0000, Jon TURNEY wrote:

> On 14/03/2011 18:23, Gaetan Nadon wrote:
> > On Mon, 2011-03-14 at 08:18 -0700, Dan Nicholson wrote:
> > 
> >> I think to be correct you need -I$(top_srcdir) and -I$(top_builddir)
> >> so you get both sessreg.h and config.h (included through sessreg.h).
> >> The alternative is to leave filenames.sed.c in the top directory and
> >> ensure it gets built before descending to the man directory.
> > 
> > 
> > Sounds good, there should be no -I.. ragardless.
> > 
> > I have posted a set of remaining patches to replace the cpp stuff with
> > plain robust man pages.
> > I had found many issues with the current man pages in terms of content.
> > These patches also fix the current build problem.
> 
> Attached is an updated patch using both -I$(top_srcdir) and -I$(top_builddir),
> I'm not sure why I thought just -I$(top_srcdir) was sufficent.
> 
> If you aren't going forward with your other suggested patches to sessreg, can
> I get a r-b: for this?


Sure.

Reviewed-by: Gaetan Nadon <mems...@videotron.ca>

> _______________________________________________
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to