On Tue, Mar 29, 2011 at 06:12:35PM +0300, Tiago Vignatti wrote:
> Signed-off-by: Tiago Vignatti <[email protected]>
> ---
>  xkb/ddxList.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/xkb/ddxList.c b/xkb/ddxList.c
> index 9623cb6..3d301d8 100644
> --- a/xkb/ddxList.c
> +++ b/xkb/ddxList.c
> @@ -222,8 +222,10 @@ char     tmpname[PATH_MAX];
>      list->nFound[what]= 0;
>      free(buf);
>      buf = malloc(PATH_MAX * sizeof(char));
> -    if (!buf)
> +    if (!buf) {
> +        fclose(in);
>          return BadAlloc;
> +    }
>      while ((status==Success)&&((tmp=fgets(buf,PATH_MAX,in))!=NULL)) {
>       unsigned flags;
>       register unsigned int i;
> -- 
> 1.7.0.4

usually referred to as file descriptor leak but
Reviewed-by: Peter Hutterer <[email protected]>

Cheers,
  Peter
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to