On Fre, 2011-04-08 at 09:13 +0200, Michel Dänzer wrote:
> On Don, 2011-04-07 at 23:47 +0300, Timo Aaltonen wrote:
> > diff --git a/src/sis_utility.c b/src/sis_utility.c
> > index 64d8919..0892cf5 100644
> > --- a/src/sis_utility.c
> > +++ b/src/sis_utility.c
> > @@ -523,7 +523,7 @@ SISSwitchCRT2Type(ScrnInfoPtr pScrn, ULong newvbflags,
> > Bool quiet)
> > }
> > #endif
> >
> > - if((!(newvbflags & CRT2_ENABLE)) && (!newvbflags & DISPTYPE_CRT1)) {
> > + if((!(newvbflags & CRT2_ENABLE)) && (!(newvbflags & DISPTYPE_CRT1))) {
> > if(!quiet) {
> > xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
> > "CRT2 can't be switched off while CRT1 is off\n");
>
> The outer parens around the ! expressions are superfluous. The bug was
> just that the ! was inside the existing parens instead of outside them.
Never mind, I see this matches the style of the existing test that
actually got this logic right.
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
