I don't see any on-list discussion about this question: Why does this patch also switch from using serverClient to using NullClient?
Assuming that was intentional, I'd suggest a comment in the commit message. Jamey On Fri, Apr 15, 2011 at 09:42:09PM +0300, [email protected] wrote: > From: Ville Syrjälä <[email protected]> > > ChangeGC changes the GC, so ValidateGC should be called after it, not > before. > > Signed-off-by: Ville Syrjälä <[email protected]> > Reviewed-by: Keith Packard <[email protected]> > Reviewed-by: Adam Jackson <[email protected]> > Reviewed-by: Daniel Stone <[email protected]> > --- > v3: unchanged > > composite/compalloc.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/composite/compalloc.c b/composite/compalloc.c > index e4064f6..e840ee8 100644 > --- a/composite/compalloc.c > +++ b/composite/compalloc.c > @@ -562,9 +562,8 @@ compNewPixmap (WindowPtr pWin, int x, int y, int w, int > h, Bool map) > { > ChangeGCVal val; > val.val = IncludeInferiors; > - > + ChangeGC (NullClient, pGC, GCSubwindowMode, &val); > ValidateGC(&pPixmap->drawable, pGC); > - ChangeGC (serverClient, pGC, GCSubwindowMode, &val); > (*pGC->ops->CopyArea) (&pParent->drawable, > &pPixmap->drawable, > pGC, > -- > 1.7.3.4 > > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
