On Mon, Apr 25, 2011 at 11:25:04AM -0700, Jeremy Huddleston wrote: > -#define Mask(n) ((n) == 32 ? 0xffffffff : ((1 << (n))-1)) > +/* Returns a CARD16 mask, n wide. */ > +/*@ requires 0 <= n <= 16 but does not enforce it */ > +#define Mask(n) ((1 << (n)) - 1)
Reviewed-by: Jamey Sharp <[email protected]> Although I'd like confirmation from keithp or somebody that this makes sense. Also, the "/*@ requires ..." was an annotation in the ACSL specification language used in Frama-C; but those annotations can't actually be applied to macro definitions, so it was a silly suggestion. If it had been valid, the "but does not enforce it" note would have broken the annotation. :-) You might just delete the comment, or at least the at-symbol. Jamey
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
