On Mon, 9 May 2011 18:31:34 -0700, Jeremy Huddleston <jerem...@apple.com> wrote: > > This was previously computed but never passed on to the caller. > > Found-by: clang static analyzer > Signed-off-by: Jeremy Huddleston <jerem...@apple.com>
Bonus cleanup of the rest of the code. Nice. Looks like I don't get to complain about 4-space indents, because I've got them all over the code. Sigh. > --- > configure.ac | 2 +- > main.c | 83 > +++++++++++++++++++++++++++++++++++---------------------- > rendercheck.h | 5 +++- > tests.c | 2 + > 4 files changed, 58 insertions(+), 34 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 4fa5a63..09b07bd 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -22,7 +22,7 @@ XORG_DEFAULT_OPTIONS > AC_CHECK_HEADERS([err.h]) > > # Checks for pkg-config packages > -PKG_CHECK_MODULES(RC, [xrender x11]) > +PKG_CHECK_MODULES(RC, [xrender x11 xproto >= 7.0.17]) What's this about? Seems like a separate commit kind of thing. > +void print_tests(FILE *file, int tests) { > + int i, j; > + > + for(i=0, j=0; available_tests[i].name; i++) { > + if(!(available_tests[i].flag & tests)) > + continue; > + if(j % 5 == 0) { > + if(j != 0) > + putc('\n', stderr); > + putc('\t', stderr); > + } else { > + fprintf(stderr, ", "); > + } > + fprintf(stderr, "%s", available_tests[i].name); > + j++; > + } > + if(j) > + fprintf(file, "\n"); > +} Spaces between "if(" and "for("
pgpm0RUtLruln.pgp
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel