On Wed, May 11, 2011 at 07:52:27PM -0700, Jamey Sharp wrote: > Looks good to me. > > Reviewed-by: Jamey Sharp <[email protected]> > > But perhaps this: > > On Thu, May 12, 2011 at 12:35:36PM +1000, Peter Hutterer wrote: > > @@ -1952,7 +1967,7 @@ ActivateImplicitGrab(DeviceIntPtr dev, ClientPtr > > client, WindowPtr win, > > grabtype = GRABTYPE_CORE; > > else if (type == DeviceButtonPress) > > grabtype = GRABTYPE_XI; > > - else if (XI2_EVENT(event) && ((xGenericEvent*)event)->evtype == > > XI_ButtonPress) > > + else if (xi2_get_type(event) == XI_ButtonPress) > > { > > type = ((xGenericEvent*)event)->evtype; > > grabtype = GRABTYPE_XI2; > > should be: > > else if ((type = xi2_get_type(event)) == XI_ButtonPress) > grabtype = GRABTYPE_XI2; > > ?
amended, thank you Cheers, Peter _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
