On Wed, May 18, 2011 at 10:35:22AM +0100, Daniel Stone wrote:
> Hi,
> 
> On Wed, May 18, 2011 at 03:00:57PM +1000, Peter Hutterer wrote:
> > On Apple keyboards, the multimedia function keys are overlaid with the F
> > keys. F1 is also BrightnessDown, F10 is Mute, etc.
> 
> Well, not just Apple: it's fairly common to have your Fn overlay.  So
> maybe a more generic name is in order?
> 
> > The kernel provides a tweak to enable/disable this.
> 
> Admittedly, this is much less common. :)
> 
> > +#define APPLE_VENDOR 0x5ac
> > +#define APPLE_KEYBOARD 0x220
> 
> You might need a table here, as the IDs on my MacBook Air are 05ac:0220.

yeah, see the last patch in this series. I kept them separate for easier
reviewing but I'll squash them in for the next revision.

> Aside from that, for the series:
> Reviewed-by: Daniel Stone <[email protected]>

thanks
 
Cheers,
  Peter
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to