Hi Peter, Peter Hutterer <[email protected]> (19/05/2011): > We've broken the ABI with some commit and drivers built against ABI 10 > happily segfault now.
not reproduced with the virtualbox thingy, but trivially reproduced with the ati driver. > Hints as to which commit actually broke it would be appreciated, I > didn't really look hard. git bisect between 1.10.0 and master points to: | commit 51f353d0a0d116af16d7d9590cadef6c56328746 | Author: Adam Jackson <[email protected]> | Date: Mon Feb 28 13:10:20 2011 -0500 | | dix: Fix ATOM typedef | | unsigned long is needlessly large on LP64. Use uint32_t instead. | | Reviewed-by: Daniel Stone <[email protected]> | Signed-off-by: Adam Jackson <[email protected]> Reverting that partially (see attached patch) makes ati work again for trivial tasks (I didn't test xv, glx, and compositing very heavily), with current master. (I haven't rebuilt ati at all, was built against 1.10, and not changed since then.) Mraw, KiBi.
From 4744b04ca10ae87ae16496f14a59b0966275e6c7 Mon Sep 17 00:00:00 2001 From: Cyril Brulebois <[email protected]> Date: Mon, 23 May 2011 14:39:54 +0200 Subject: [PATCH] Revert "dix: Fix ATOM typedef" This partially reverts commit 51f353d0a0d116af16d7d9590cadef6c56328746. Keep <stdint.h> anyway, since it's needed in other places; but revert the ATOM typedef change itself, which (at least) broke the video ABI. Signed-off-by: Cyril Brulebois <[email protected]> --- include/misc.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index bdcc8cc..ac92a8c 100644 --- a/include/misc.h +++ b/include/misc.h @@ -92,7 +92,7 @@ OF THIS SOFTWARE. #define EXTENSION_EVENT_BASE 64 #define EXTENSION_BASE 128 -typedef uint32_t ATOM; +typedef unsigned long ATOM; #ifndef TRUE #define TRUE 1
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
