* Alan Coopersmith <[email protected]>, 20110625 06:58:
> Looks good to me - pushed to git master.

Thanks! Unfortunately, I seem to have introduced a small bug. I tried
building the code on FreeBSD 9 and Linux, but I forgot to test it on
FreeBSD 8, where we have to include <sys/types.h> before using <utmp.h>.

The attached patch seems to fix this.

-- 
 Ed Schouten <[email protected]>
 WWW: http://80386.nl/
From 42e3ce68f68471ff714167b0e2860c36dda82efd Mon Sep 17 00:00:00 2001
From: Ed Schouten <[email protected]>
Date: Sat, 25 Jun 2011 10:35:25 +0200
Subject: [PATCH] Don't forget to include <sys/types.h> before <utmp.h>.

Some operating systems (e.g. FreeBSD) require <sys/types.h> to be
included before <utmp.h>, because they depend on type definitions such
as int32_t, time_t, etc.

Signed-off-by: Ed Schouten <[email protected]>
---
 configure.ac |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index be90cf3..6d616ae 100644
--- a/configure.ac
+++ b/configure.ac
@@ -48,7 +48,10 @@ AC_CHECK_MEMBERS([
 	struct utmp.ut_host,
 	struct utmp.ut_id,
 	struct utmp.ut_pid,
-	struct utmp.ut_type], [], [], [#include <utmp.h>])
+	struct utmp.ut_type], [], [], [
+	#include <sys/types.h>
+	#include <utmp.h>
+	])
 AC_CHECK_MEMBERS([struct utmpx.ut_syslen], [], [], [#include <utmpx.h>])
 
 # Checks for library functions.
-- 
1.7.5.4

Attachment: pgplc5oBiwPVi.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to