On Tue, 2011-07-05 at 09:47 +1000, Peter Hutterer wrote: > On Fri, Jul 01, 2011 at 06:04:28AM -0700, Dan Nicholson wrote: > > On Thu, Jun 30, 2011 at 10:01 AM, Gaetan Nadon <[email protected]> wrote: > > > This reverts commit 4005df66072ceac175ea71427deb16176262f197. > > > > > > The patch introduces a couple of issues. > > > 1) These tools are apps and conceptually do not depend on Xserver, > > > so XORG_CFLAGS should not be used. It included pixman header files. > > > Only drivers depend xserver > > > > This is not true here. synclient includes <xserver-properties.h> so it > > can use the input properties designated by the server. > > > As I understand, this is handled by the -I$(sdkdir) in the patch (instead of > $XORG_CFLAGS). Having said this, the dependency on the header can easily be > removed.
That's the reason for -I$(sdkdir) rather than XORG_CFLAGS. In previous patches reviewers have commented that XORG_CFLAGS should not be used for tools. Having seen Peter's patch, it's great to remove the dependency on xserver_properties. It will be much clearer now. > > Cheers, > Peter > > > I don't see a > > reason to revert this patch. It seems to have good fixes in it. >
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
