On Wed, Aug 10, 2011 at 01:46:58PM +0100, Daniel Stone wrote:
> On Wed, Aug 10, 2011 at 01:10:32PM +0200, Luc Verhaegen wrote:
> > Signed-off-by: Luc Verhaegen <[email protected]>
> > @@ -866,9 +866,11 @@ dynamic changes in the display environment.
> >  ????????????
> >     Errors: Atom, Output
>                             ^^^^^^^^
>                             , Access

I completely missed that one.

> > +   If the specified property does not exist, a Match error is returned. If
> > +   the property is marked 'immutable', an Access error is returned.
> 
> s/Match/Atom/

True. But it really needs further quantification: it could be that the 
property does not belong to this output. The code in the other patch 
handles that, and it is that one that returns the Match error.

New patch coming up.

... Although... After scrolling up a bit in randproto.txt...

For RRQueryOutputProperty it states the following:

"If the specified property does not exist for the specified output,
then a Name error is returned."

Or in ProcRRQueryOutputProperty

    prop = RRQueryOutputProperty (output, stuff->property);
    if (!prop)
        return BadName;

I will need to change this in rrproperty.c as well.

Luc Verhaegen.
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to