On Wed, Aug 17, 2011 at 10:25 AM, Peter Harris <[email protected]> wrote: > On 2011-08-16 22:58, Matt Turner wrote: >> Swapping the wrong size was never caught because swap{l,s} are macros. > >> --- a/xkb/xkb.c >> +++ b/xkb/xkb.c >> @@ -6190,7 +6190,6 @@ char * str; >> swaps(&rep.supported); >> swaps(&rep.unsupported); >> swaps(&rep.nDeviceLedFBs); >> - swapl(&rep.type); > + swaps(&rep.dfltKbdFB); > + swaps(&rep.dfltLedFB); > + swapl(&rep.devType); > > Otherwise, > Reviewed-by: Peter Harris <[email protected]> > > Thanks for fixing up swapping. > > Peter Harris > -- > Open Text Connectivity Solutions Group > Peter Harris http://connectivity.opentext.com/ > Research and Development Phone: +1 905 762 6001 > [email protected] Toll Free: 1 877 359 4866
Good catch. Let's make that a separate patch on top of my series (so you'll get credit for finding it as well) Thanks, Matt _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
