On Sun, 2011-09-04 at 16:27 +0200, walter harms wrote: > IMHO to have yyparse() etc. is ok. If someone complains we/you can > revert the change. cleaning up seems more important now.
I did some more searching. I found a couple of posts where name clashing did occur (not with X). Other modules in X using lex & yacc are the server and apps, but this module is a library and more prone to name clashing. Looking at external symbols of X libraries, it shows that they have a prefix, for example, Xaw. In fact, a prefix for libraries external symbols is a GNU coding standard. One thing I don't know is if these yy* symbols should be external symbols or not. If yes, they should have an Xaw3d prefix, otherwise they should be made invisible. I don't know if this would be possible, however. > > What confuses me is why does it come up here (Layout.c) > I would expect it with Layout.h > > Maybe because the author did not want those to be in the public headers space (include/X11/Xaw3d/Layout.h).
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
