On Sep 15, 2011, at 9:29 PM, Alan Coopersmith wrote: > On 09/14/11 15:25, Aaron Plattner wrote: >> These symbols were not renamed when they were added to libfb: >> >> # nm -D libwfb.so | grep ' fb' >> 0000000000028d00 T fbTrapezoids >> 0000000000028d60 T fbTriangles >> >> This causes corruption and/or crashes on wfb-ful drivers like nvidia: > > Is there any simple/portable way to automate the name list generation or > at least test that it's correctly done at build time? It would be nice > to not have to worry about manual updates being needed for every change. > > On Solaris, I can get the equivalent output with: > > % nm -pg libwfb.so | grep ' fb' > 00000000000000218380 T fbTrapezoids > 00000000000000219112 T fbTriangles > > but I'm not sure that's the best test, and clearly would need portability > help. wfb seems like a candidate for -export-symbols-regex '^wfb.*' but > then it would be even harder to detect problems. > > If nothing else, should there be a comment early on in fb/*.h advising > people when a wfbrename.h entry would be needed? > > And presumably because of the crashes this is a 1.11 stable release > candidate as well, right?
Yes. I'll cherry-pick it once it lands on master. Keith, can you please go through your PULL/PATCH queue this weekend, so I can get an rc1 out next week? Thanks. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
