Hi, On 30 September 2011 17:18, Chase Douglas <[email protected]> wrote: > On 09/29/2011 09:29 PM, Peter Hutterer wrote: >> Using this call simplifies callers that don't know if the mask bit is set. >> >> Before: >> if (valuator_mask_isset(mask, valnum)) >> value = valuator_mask_get_double(mask, valnum)); >> else >> value = someothervalue; >> >> Now: >> if (!valuator_mask_fetch_double(mask, valnum, &value)) >> value = someothervalue; >> >> Signed-off-by: Peter Hutterer <[email protected]> > > I think this will help clean up code all over :). > > Reviewed-by: Chase Douglas <[email protected]>
Yeah, seriously. Is there any good reason to not make a double which returns either 0.0 (if not set) or the mask value (if set) though, on the grounds that anyone who wants to know will be using isset/get_double? Cheers, Daniel _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
