On Mon, 2011-10-03 at 16:16 -0700, Jamey Sharp wrote: > On Mon, Oct 03, 2011 at 12:03:33PM +0200, Michel Dänzer wrote: > > On Sam, 2011-10-01 at 23:08 -0700, Jamey Sharp wrote: > > > In the process, move reference counting into FreePixmap instead of > > > doing it inconsistently in the various screen hooks. > > > > I like the series, the only minor nit being that the name 'FreePixmap' > > still implies that the pixmap is freed immediately. How about something > > like 'UnreferencePixmap' or an abbreviation thereof? > > Good point. Josh suggested ReleasePixmap, which I like. (I try to pick > short words instead of abbreviating long ones.)
Good choice. > I've updated my pixmap-hooks branch with that change, which didn't > affect the other two patches. > > git://anongit.freedesktop.org/~jamey/xserver pixmap-hooks > http://cgit.freedesktop.org/~jamey/xserver/log/?h=pixmap-hooks > > Would you like to provide a Reviewed-by now that I've made that change? Reviewed-by: Michel Dänzer <[email protected]> -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
