On Mon, Oct 10, 2011 at 9:04 PM, Antoine Martin wrote: > And another blooper, sorry for the spam. Correct patch attached. > Need sleep, will pick this up tomorrow.
> Subject: [PATCH xserver] check for elevated privileges not uid=0 (V3) > > Couldn't find any reference to it, so I just removed it. To avoid confusion, you should version your patches. What I said was to put the version inside the bracketed part. And if your code changes are limited to the hw/xfree86 tree, you might add xfree86 as a prefix. Just as a suggestion, feel free to rephrase: Subject: [PATCH v3] xfree86: Check for elevated privileges instead of just uid==0 + /* XXX ouch, coudn't get back to original uid + what can we do ??? */ You do not need a comment if you have an explaining error message. Otherwise, comments should also be properly spelled and reflect the quality of the code. Cheers, Tormod _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
