Hi, On 12 October 2011 09:59, Dave Airlie <airl...@gmail.com> wrote: > The test was memsetting the wrong thing, this fixes make check in my > tinderbox.
Rather. > +++ b/test/input.c > @@ -1315,11 +1315,11 @@ static void dix_get_master(void) > memset(&kbd, 0, sizeof(DeviceIntRec)); > memset(&floating, 0, sizeof(DeviceIntRec)); > > - memset(&vcp_sprite, 0, sizeof(DeviceIntRec)); > - memset(&vck_sprite, 0, sizeof(DeviceIntRec)); > - memset(&ptr_sprite, 0, sizeof(DeviceIntRec)); > - memset(&kbd_sprite, 0, sizeof(DeviceIntRec)); > - memset(&floating_sprite, 0, sizeof(DeviceIntRec)); > + memset(&vcp_sprite, 0, sizeof(SpriteInfoRec)); > + memset(&vck_sprite, 0, sizeof(SpriteInfoRec)); > + memset(&ptr_sprite, 0, sizeof(SpriteInfoRec)); > + memset(&kbd_sprite, 0, sizeof(SpriteInfoRec)); > + memset(&floating_sprite, 0, sizeof(SpriteInfoRec)); But changing these to: memset(&vcp_sprite, 0, sizeof(vcp_sprite)); et al would be even better ... With that: Reviewed-by: Daniel Stone <dan...@fooishbar.org> Cheers, Daniel _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel