On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlie<[email protected]>
newPix could be leaked if AddResource failed.
pointed out by coverity scan.
Signed-off-by: Dave Airlie<[email protected]>
---
composite/compext.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/composite/compext.c b/composite/compext.c
index 722587a..01bd578 100644
--- a/composite/compext.c
+++ b/composite/compext.c
@@ -725,8 +725,10 @@ PanoramiXCompositeNameWindowPixmap (ClientPtr client)
}
if (!AddResource (newPix->info[i].id, RT_PIXMAP,
- (pointer) pPixmap))
+ (pointer) pPixmap)) {
+ free (newPix);
return BadAlloc;
+ }
++pPixmap->refcnt;
}
Reviewed-by: Alan Coopersmith <[email protected]>
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
