On Oct 20, 2011, at 12:08, Julien Cristau wrote:

>>      if (xnestParentWindow != (Window) 0 &&
>>        X.xdestroywindow.window == xnestParentWindow)
>> +    CloseWellKnownConnections();
>> +    OsCleanup(1);
>>      exit (0);
> That looks broken, don't you need braces around the if branch?  Also I'm
> not quite sure what's the point of doing manual cleanup when you're
> going to exit() on the next line anyway.  So this hunk looks like it
> should be reverted.

Yeah.  I dunno what I was doing there, but it's obviously wrong... 

While your at it, care to review my other pending Xnest change, so I can send 
both in a [PULL]?

I'm assuming your r-b for the revert of the above hunk.

--Jeremy

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to