On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston <[email protected]> wrote: > So, what's the point of having all these in common? Why don't they just live > in the drivers? It seems silly to have these defined in the server's SDK > rather than the driver that will consume them, since it means the driver will > need to do > > #ifndef PCI_CHIP_GD7556 > #define PCI_CHIP_GD7556 0x004C > #endif > > if it wants to work on older servers without the change ...
Yes, should we move this to the drivers and make them stop including xf86PciInfo.h? Are the PCI_CHIP_ macros used by anything else than the drivers, or can they be taken out as soon as drivers are updated? The server itself is not using them, according to git grep. I will follow up with a radeon patch, it currently has a mix of both, and see how that is received. The #ifndef dance it not necessary on gcc at least, as long as a redefine uses the same value. Tormod > > On Oct 17, 2011, at 1:48 AM, Jeremy Huddleston wrote: > >> >> https://bugs.freedesktop.org/show_bug.cgi?id=1837 >> >> Signed-off-by: Jeremy Huddleston <[email protected]> >> --- >> hw/xfree86/common/xf86PciInfo.h | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/hw/xfree86/common/xf86PciInfo.h >> b/hw/xfree86/common/xf86PciInfo.h >> index 356c7db..2825ece 100644 >> --- a/hw/xfree86/common/xf86PciInfo.h >> +++ b/hw/xfree86/common/xf86PciInfo.h >> @@ -386,6 +386,7 @@ >> /* Cirrus Logic */ >> #define PCI_CHIP_GD7548 0x0038 >> #define PCI_CHIP_GD7555 0x0040 >> +#define PCI_CHIP_GD7556 0x004C >> #define PCI_CHIP_GD5430 0x00A0 >> #define PCI_CHIP_GD5434_4 0x00A4 >> #define PCI_CHIP_GD5434_8 0x00A8 >> -- >> 1.7.6.1 >> >> >> _______________________________________________ >> [email protected]: X.Org development >> Archives: http://lists.x.org/archives/xorg-devel >> Info: http://lists.x.org/mailman/listinfo/xorg-devel > > > > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel > _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
