Hi, On 2 November 2011 01:14, Alan Coopersmith <alan.coopersm...@oracle.com> wrote: > On 11/01/11 17:50, Daniel Stone wrote: >> On 1 November 2011 22:42, Alan Coopersmith<alan.coopersm...@oracle.com> >> wrote: >>> When we want to print a string, it's okay to just print it. >>> We don't need to first allocate a buffer 2 bytes bigger than the >>> string, copy the entire string unmodified to the buffer, print the >>> buffer, and then leak the buffer (though we AbortDDX 8 lines later, >>> and then just in case we survived that, call exit as well, so the >>> leak is short lived, just oh so pointless). >>> >>> Oh, and for good measure, put the "r" in String, no matter how >>> much it stings. >> >> Bonus points if you felt like just removing optionTypeToSting, now >> that it's unused. > > It's still used - I just put the call directly in the ErrorF > argument, instead of storing in a variable: > > + ErrorF ("\t%s:%s\n", p->name, > + > optionTypeToString(p->type));
Sure, that's optionTypeToSt_R_ing -- optionTypeToSting is now a sad unwanted orphan. (Yes, there were two functions named mostly the same thing, doing mostly the same thing.) Cheers, Daniel _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel