On 11/07/11 11:57, Matthieu Herrb wrote:
This logically reverts 7e223d3ac6c0d549a7d6e4dcc86a053e19594028.
There are still cases (in particular OpenBSD) where the shared greeter
is not desired.
As discussed elsewhere in this thread, I'm okay with the concept of this patch,
though I have a couple nits about the implementation:
+if test "x$DYNAMIC_GREETER" = "xno"; then
+STATIC_GREETER_CFLAGS="-DGREET_USER_STATIC"
+STATIC_GREETER_LIBS="-L../greeter -lXdmGreet"
+fi
A little indentation of the middle two lines would be nice.
AM_CPPFLAGS = -I$(top_srcdir)/include
AM_CFLAGS = $(CWARNFLAGS) $(XDMGREET_CFLAGS) -DGREET_LIB
+#ifdef GREET_LIB
I don't understand the point of adding #ifdef GREET_LIB when you leave it
hardcoded in the Makefile as always defined.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
