On 12/13/11 14:31, Adam Jackson wrote:
gcc doesn't want to hoist the check for XaceHooks[hook] != NULL above the varargs code for some reason, so do it ourselves.
Perhaps because it would have to do some gymnastics to realize that in all cases we happen to either initialize prv to NULL or a pointer to a struct member initialized to Success, and that it really is equivalent to the return prv ? *prv : Success when the inlined CallCallbacks determines there's nothing to do there. (At least it took me a couple reads through the code to realize myself that this really does just fastpath that case and does not change the semantics of it.) Reviewed-by: Alan Coopersmith <[email protected]> -- -Alan Coopersmith- [email protected] Oracle Solaris Platform Engineering: X Window System _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
