On 01/26/2012 01:46 PM, Daniel Stone wrote:
On 26 January 2012 22:36, Dave Airlie<[email protected]>  wrote:
From: Dave Airlie<[email protected]>

At least the intel, nouveau and radeon driver contain this chunk of code.

We should move it into the server just for the sake of stopping further 
cut-n-paste.

Drivers can be adapted to use it later.

Signed-off-by: Dave Airlie<[email protected]>

Can you not drop the ScreenPtr argument and just say that the function
relies on ScrnInfoPtr::pScreen being valid?

It would presumably be typically called from ScreenInit, where pScrn->pScreen is NULL.

If you want to have the server wire that up earlier, that'd be another matter.

With that:
Reviewed-by: Daniel Stone<[email protected]>

Cheers,
Daniel
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to