On Tue, 7 Feb 2012 17:57:47 +1000, Peter Hutterer <[email protected]> wrote:
> Chase Douglas (7): > Store window pointer in touch listener record > Factor out TouchEnd generation and delivery > Export TouchEventRejected as TouchRejected > Move AllowTouch to dix/touch.c, and rename to TouchAcceptReject > Check for proper window ID when processing touch allow requests > Implement early touch reject > Implement touch early accept These have all been reviewed by Peter. > > Peter Hutterer (2): > Revert "dix: deduplicate callers of DeliverDeviceEvents in > DeliverGrabbedEvents" This reverts a (failed) attempt to clean up this code. Reviewed-by: Keith Packard <[email protected]> > Xi: check request size for xXIAllowEvents based on client version This one looks wrong to me -- xXIAllowEventsReq is 20 bytes long in the server, so any old clients sending only 12 bytes will get a length error. I think the protocol should declare both structures, much as randrproto does for SetScreenConfig (although, I think that's backwards -- use a new struct for the new request). Then you can check the size in the server by comparing with the struct appropriate for the client version. You need to also reject old clients that send XIRejectTouch or XIAcceptTouch values to avoid walking off the end of the request. -- [email protected]
pgpfVVhaEzd4u.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
