On Wed, Feb 08, 2012 at 08:59:28AM -0800, Keith Packard wrote: > <#part sign=pgpmime> > On Wed, 8 Feb 2012 19:18:17 +1000, Peter Hutterer <[email protected]> > wrote: > > > +/* for GetRequest() to work */ > > +#define X_XI2_2AllowEvents X_XIAllowEvents > > Should that be in the protocol header file?
not really, this is just the opcode needed for libX11's GetReq() macro to work. It expands the opcode based on the argument, the opcode for both the old and the new version of the request is identical tough. Thus, IMO we should not leak libXi implementation detail into the protocol. Cheers, Peter > Otherwise, this looks good to me. > > Reviewed-by: Keith Packard <[email protected]> > > -- > [email protected] _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
