On Fri, Feb 10, 2012 at 10:24:22PM +0100, Chase Douglas wrote: > On 02/10/2012 09:38 PM, Peter Hutterer wrote: > > On Fri, Feb 10, 2012 at 11:56:44AM -0800, Chase Douglas wrote: > >> This new series includes fixes to make the eventcomm-test execute > >> properly. You > >> can run "make check" to test. > >> > >> Patch 01 was added to fix eventcomm-test since it's currently broken. > >> > >> Patch 02, 07, 09, and 10 were changed to move the SynapticsHwState > >> functions > >> into a new source file src/synproto.c. This is necessary so eventcomm-test > >> can > >> link them in without pulling the rest of src/synaptics.c. > >> > >> Patch 03 was added to make eventcomm-test work with the new > >> SynapticsHwState > >> scheme. > > > > Reviewed-by: Peter Hutterer <[email protected]> for the series except > > where otherwise noted. The only minor thing I want fixed is the eventcomm > > stuff in 01/14 and the follow-up, if you can fix those up in your repo I'll > > pull it asap. > > I added a helper function to allocate the proto data in patch 01. I also > edited the touch initialization in the open_slots patch. I moved > everything into a separate function. > > I didn't bother adding your reviewed-by tags since you'll have to add > your SOB tags anyways. These changes are pushed to my repo: > > http://cgit.freedesktop.org/~cndougla/xf86-input-synaptics > multitouch-synaptics > > Do you want me to resend anything to the list?
nah, I just pulled them directly, thanks. 49f6109..e6032c3 master -> master I do wonder if it's worth adding an option that disables all driver gestures that would otherwise interfere with MT. took me a bit to find and disable all settings to get touch events. Cheers, Peter _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
