----- Original Message ----- > On 12-03-12 03:12 PM, Jakob Bornecrantz wrote: > > ----- Original Message ----- > >> Use AM_CONDITIONAL. Automake knows what to distribute. > >> It needs to be able to navigate down the subdirs to find what > >> needs to be included in the tarball. > >> > >> To test reliably, create a tarball and expand it into a separate > >> directory and build with xatracker. Distcheck will not detect > >> missing code when such code is configured not to build. > >> > >> The content of a tarball *must* always be identical, regardless > >> of the configuration options used or on which platform it was > >> configured. > >> > >> Signed-off-by: Gaetan Nadon <[email protected]> > > Thanks, I had just done a simpler patch, but less correct then > > yours, so I'll rather use this. > > > > Do we really need to do the conditional in all the > > Makefile.am's according to the link below that isn't needed > > and it will figure out DIST_SUBDIRS correctly? > > No, not really. Like any coding job, there are different ways of > doing it with different pros and cons. These are some of the > experiences I had which influence my choices: > > Developers often end-up in a Makefile without having gone through > configure.ac, hence they don't know statements in there that might > affect the Makefile. They would not even notice that vmwglx is > conditionally compiled. One may invoke make from the vmwglx subdir on > a system that does not have the xatracker and waste time chasing > ghost problems. It's confusing when 'make' does not behave the same > when invoked from subdirs. > > The /src makefile still needs a conditional. It can be done through > configure.ac but that increases this file complexity. > > I can see cases where a conditional SUBDIRS would be preferable. Over > time you get used to do it one way over the other. There is really > nothing wrong, feel free to change it.
Ok, thanks, it was just that the change looked a lot bigger then it needed to be. > > BTW, saa can always be built, right? That would help finding compiler > errors and be subject to distcheck verification. That would leave us > with just the vmwglx subdir to be conditionally skipped. > I think SAA uses the xatracker to do the acceleration. > Also, if you feel like it, AC_SYS_LARGEFILE does not really need to > be in a condition. It's harmless and can go with other AC_ > statements at the top in the "Initialize Autoconf" section. Ok, can you please respin the patch with that change, you can leave the SUBDIRS alone, I have no real strong feelings either way. Thanks again. Cheers, Jakob. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
