Matt Turner schrieb:
Found at 
http://gitorious.org/xaw3d/xaw3d/commit/bef54db66ae333f2e741186ca423325d17c58eb9

Same fix appeared in libXaw as part of XFree86 4.3.0.1.

XFree86's CVS says 'fix-trackers 3637-3977' for this change,
but I have no idea what those numbers correspond to.

http://cvsweb.xfree86.org/cvsweb/xc/lib/Xaw/MultiSrc.c.diff?r1=1.1&r2=1.2

Signed-off-by: Matt Turner<[email protected]>
---
I don't know what this actually fixes.

  src/MultiSrc.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/MultiSrc.c b/src/MultiSrc.c
index b53fa50..1ac3283 100644
--- a/src/MultiSrc.c
+++ b/src/MultiSrc.c
@@ -728,6 +728,7 @@ SetValues(Widget current, Widget request, Widget new, 
ArgList args, Cardinal *nu

    if ( string_set || (old_src->multi_src.type != src->multi_src.type) ) {
      RemoveOldStringOrFile(old_src, string_set);
+    src->multi_src.allocated_string = old_src->multi_src.allocated_string;
      file = InitStringOrFile(src, string_set);

      /* Load pieces does this logic for us, but it shouldn't.  Its messy.*/
This patch is fixing the following bug:

http://gnats.netbsd.org/37610

I cite from that link:

Description:
Xaw3d may crash an application if an internationalized text widget's value is updated by the program, and useStringinPlace is False (default value) - xaw3d tries to free the incorrect address. I suspect Xaw-Xpm has this issue as well (the patch applies as well), though I haven't tested it.




The linked bug report tells us that Redhat has been using this bugfix since Aug 09 2002, that is 9 years and a half. So this bug fix has really prooved to be stable.

It also occurs in recent GNU gv versions having international mode turned on when you try to open the file open dialog.

Greetings from Germany

Markus Steinborn
GNU gv maintainer

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to