On 05/15/2012 11:06 AM, Mark Kettenis wrote: >> From: Peter Hutterer <peter.hutte...@who-t.net> >> Date: Tue, 15 May 2012 20:26:37 +1000 >> >> I got annoyed having to write constructs like >> >> BUG_WARN(foo); >> if (foo) >> return FALSE; >> >> and similar. glib has useful macros like g_return_if_fail and similar, these >> are macros that essentially do the same job. They shout into the log, but >> otherwise continue as normal. >> >> http://developer.gnome.org/glib/2.29/glib-Warnings-and-Assertions.html#g-return-if-fail >> >> These are not macros that should be used for handling normal out-of-scope >> values, they're there to shout that there is a real bug that needs fixing. > > Still I think I agree with whoever said that hiding control flow > instructions behind a macro isn't a good idea.
I understand your viewpoint, but I don't feel the same way. I think it is obvious enough, based on the name of the macro, what is going on. I won't be terribly annoyed if these changes aren't merged, but I wanted to go on the record to say that I prefer them. -- Chase _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
