Hi Daniel, Here's some fixes for stuff I've noticed. They should be cherry-pickable.
I've also got another branch on top of this one, called "rules". It does some cleanup the rules file parser. You can pull it if you want to and if it doesn't conflict with anything you might have, or I can send it later. Thanks, Ran The following changes since commit 8ca8f05aab86423c2495cd917489becfecca4632: Add xkbcommon-uninstalled.pc (2012-05-18 01:05:14 +0100) are available in the git repository at: [email protected]:bluetech/libxkbcommon.git fixes for you to fetch changes up to beccc375095c921b8c212b0f992ae88c87ca95ca: Don't run the benchmark by default (2012-05-20 20:31:19 +0300) ---------------------------------------------------------------- Ran Benita (9): Fix configure check for xkbparse.c instead of parser.c Fix a memleak Various static analyzer fixes Revert "Fix KeyInfo's syms array size calculation" Remove unused allowNone from KeyInfo Remove FileHandler callback argument Change xkb_map_new_from_fd to use FILE* Create path.h for the path.c functions Don't run the benchmark by default Makefile.am | 1 + configure.ac | 4 ++-- include/xkbcommon/xkbcommon.h | 7 ++++--- src/alloc.c | 2 +- src/context.c | 2 +- src/rules.c | 1 + src/xkbcomp/alias.c | 3 +-- src/xkbcomp/compat.c | 14 ++++++------- src/xkbcomp/keymap.c | 2 +- src/xkbcomp/keytypes.c | 14 ++++++------- src/xkbcomp/misc.c | 1 + src/xkbcomp/parseutils.c | 1 + src/xkbcomp/path.c | 2 +- src/xkbcomp/path.h | 45 +++++++++++++++++++++++++++++++++++++++++ src/xkbcomp/symbols.c | 27 +++++++++++++------------ src/xkbcomp/xkbcomp-priv.h | 11 ---------- src/xkbcomp/xkbcomp.c | 29 ++++++++++++-------------- test/filecomp.c | 15 ++++++-------- test/rulescomp.c | 4 +++- 19 files changed, 110 insertions(+), 75 deletions(-) create mode 100644 src/xkbcomp/path.h _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
