On 05/23/2012 08:32 PM, Peter Hutterer wrote: > pulled the branch you sent me that contained (amongst others) this patchset. > > On Fri, May 18, 2012 at 02:02:04PM -0700, Chase Douglas wrote: >> Signed-off-by: Chase Douglas <[email protected]> >> --- >> Changes since v2: >> * Refreshed xorg-gtest.m4 and Makefile-xorg-gtest.am for xorg-gtest changes >> >> configure.ac | 21 +++++- >> m4/xorg-gtest.m4 | 110 >> +++++++++++++++++++++++++++++++ >> test/integration/Makefile-xorg-gtest.am | 64 ++++++++++++++++++ >> test/integration/Makefile.am | 4 ++ > > What's missing here is that test/Makefile.am needs integration in the > SUBDIRS, otherwise the tests won't be built.
I could have sworn I did this, but I guess not. I've added it in. > and when building them, I get > xi2.cpp: In member function ‘virtual void > XInput2Test_DisableDeviceEndTouches_Test::TestBody()’: > xi2.cpp:308:177: error: ‘wait_for_device’ was not declared in this scope > xi2.cpp:313:162: error: ‘wait_for_event_of_type’ was not declared in this > scope > xi2.cpp:337:162: error: ‘wait_for_event_of_type’ was not declared in this > scope > > I suspect they are supposed to be in there somewhere, but neither xorg-gtest > nor this tree had it. I fixed up the XIQueryPointer test, but then when I rebased the "end touches on device disable" branch on top I forgot to fix up its test too. I guess I then didn't bother to recompile and test :(. My fault. I'll resend all five patches together so you can review the changes. The branch has been updated if you want to pull: git://people.freedesktop.org/~cndougla/xserver integration-tests Thanks, -- Chase _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
