Alan Coopersmith <[email protected]> writes: Ok, I like the general plan here, but there are a mish-mash of styles which doesn't really seem neater than the original code.
If we can, indeed, use this form:
> +
> + reply = (xQueryTreeReply) {
> + .type = X_Reply,
> + .sequenceNumber = client->sequence,
> + .root = pWin->drawable.pScreen->root->drawable.id,
> + .parent = (pWin->parent) ? pWin->parent->drawable.id : (Window) None
> + };
then I'd like to see that used uniformly as it will eliminate the need
to create artificial blocks to place new declarations and initializers
in, and will make the patch a lot easier to read -- you'd be replacing a
sequence of assignment statements with a single struct assignment.
--
[email protected]
pgp30sDFZR76Z.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
