Le 20/07/2012 18:36, Thomas Klausner a écrit : > On Fri, Jul 20, 2012 at 08:40:26AM +0200, Rémi Cardona wrote: >> Le 18/07/2012 16:47, Thomas Klausner a écrit : >>> - (void)memset(tc,0L,sizeof(tc)); >>> + (void)memset(tc,0L,sizeof(*tc)); >> >> I'd say you might as well drop the useless cast too. > > There are twelve memsets with casts, only one of them has the bug. > So do you want a second patch that removes the casts, or just remove this one > cast? > Merging them in one will hide the bug fix in the noise.
It's definitely worth an extra patch if it's more widespread than just this bit. In any case, the previous patch is: Reviewed-by: Rémi Cardona <[email protected]> Cheers, Rémi _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
