Peter Hutterer <[email protected]> writes: > Two unreviewed: the win32 fsync ifdef typo, and the fix for 53568, which > currently crashes on the first pointer event from an Option Floating device.
I've reviewed those now. > mi: don't check for core events in miPointerSetPosition (#53568) This seems very much like a 'how could that ever have been the right idea' kind of change to me -- setting the pointer position for a device shouldn't ever have depended on whether that device was delivering core events or not. In any case, the change seems obviously correct to me Reviewed-by: Keith Packard <[email protected]> However, this still looks very fragile -- fill_pointer_events does not check the return value from miPointerSetPosition, which is still allowed to return NULL in some cases. I don't think any of those are valid though, so I'd suggest that either miPointerSetPosition or positionSprite throw a fatal error instead of blindly wandering into a segfault. > os: fix typo, fsync when WIN32 is _not_ defined Reviewed-by: Keith Packard <[email protected]> -- [email protected]
pgpzLusvFuzJB.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
