Was staring at this code recently trying to figure out a bug. Didn't succeed yet, but I may as well leave it nicer than I found it. 2-4 are mostly to make the logic of the callers more readable, 5 removes a hack that Composite is no longer using. Small code size win:
text data bss dec hex filename 1573725 32090 59360 1665175 196897 Xvfb-before 1573230 32090 59360 1664680 1966a8 Xvfb-after Imperceptable performance difference: before after Operation -------- ----------------- ----------------- 1177605.5 1207342.2 ( 1.03) Map window via parent (4 kids) 1541016.2 1577507.5 ( 1.02) Map window via parent (16 kids) 1599218.2 1623316.1 ( 1.02) Map window via parent (25 kids) 1428492.1 1437949.0 ( 1.01) Map window via parent (50 kids) 1322784.9 1337675.3 ( 1.01) Map window via parent (75 kids) 1241169.2 1260609.7 ( 1.02) Map window via parent (100 kids) 983159.1 980600.2 ( 1.00) Map window via parent (200 kids) 2954438.0 2931223.6 ( 0.99) Unmap window via parent (4 kids) 5356538.3 5243219.4 ( 0.98) Unmap window via parent (16 kids) 5886038.4 5869729.0 ( 1.00) Unmap window via parent (25 kids) 6372664.9 6412601.5 ( 1.01) Unmap window via parent (50 kids) 6726258.3 6608219.8 ( 0.98) Unmap window via parent (75 kids) 6706023.1 6615141.3 ( 0.99) Unmap window via parent (100 kids) 6971058.7 6889147.0 ( 0.99) Unmap window via parent (200 kids) - ajax _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
