Colin Harrison <[email protected]> writes: > Hi, > > Thinking about this after strong coffee: all those bit-fields would be > better unsigned...
Yeah, I agree -- Adam, what do you think?
> --- ./include/save_dixstruct.h 2012-10-05 01:24:03.981982326 +0100
> +++ ./include/dixstruct.h 2012-10-05 20:13:19.803253520 +0100
> @@ -90,12 +90,12 @@ typedef struct _Client {
> Mask clientAsMask;
> short index;
> unsigned char majorOp, minorOp;
> - int swapped:1;
> - int local:1;
> - int big_requests:1; /* supports large requests */
> - int clientGone:1;
> - int closeDownMode:2;
> - int clientState:2;
> + unsigned swapped:1;
> + unsigned local:1;
> + unsigned big_requests:1; /* supports large requests */
> + unsigned clientGone:1;
> + unsigned closeDownMode:2;
> + unsigned clientState:2;
> char smart_priority;
> short noClientException; /* this client died or needs to be killed
> */
> int priority;
I'll need a signed-off-by: line at least; a regular git patch would be
even nicer.
--
[email protected]
pgpmTAhzyKi5P.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
