From: Andreas Schwab <[email protected]>

The semantics of a callback set with XtSetTypeConverter() is to return
False only if there is no conversion at all.
In this case the converstion string is copied verbatim to the target.
Since the from and to types differ this doesn't make sense here at all.
Instead the target value needs to be set to NULL and the return needs
to be True.

Signed-off-by: Egbert Eich <[email protected]>
---
 grid.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/grid.c b/grid.c
index e1f134d..49f7693 100644
--- a/grid.c
+++ b/grid.c
@@ -542,10 +542,7 @@ XmuCvtStringToXftFont(Display *dpy,
                                XScreenNumberOfScreen (screen),
                                name);
        if (!font)
-       {
            XtDisplayStringConversionWarning(dpy, (char *) fromVal->addr, 
XtRXftFont);
-           return False;
-       }
     }
     donestr (XftFont *, font, XtRXftFont);
 }
-- 
1.7.7

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to