On Fri, Nov 16, 2012 at 10:41:06AM +0100, Thomas Petazzoni wrote: > The line: > > AM_CFLAGS = $(XT_CFLAGS) > > in util/Makefile.am is wrong because it adds target cflags to the > compilation of makestrs, which is built for the build machine, which > leads to build failures when cross-compiling. > > We also remove the inclusion of <X11/Xos.h> from makestrs.c, because > it was the only non-standard header being included (and therefore > possibly requiring special cflags), but it was in reality not useful > at all to build makestrs.c. > > Signed-off-by: Thomas Petazzoni <[email protected]>
With Jon's comment addressed, this patch is: Reviewed-by: Thierry Reding <[email protected]> Tested-by: Thierry Reding <[email protected]> I've tested for x86_64 -> x86 and for x86_64 -> ARM cross-builds. Thierry
pgpC3LSyW3bpr.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
